[RATIS-1991] Optimize the reconfig judgment logic in the ReconfigurationBase class.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.1.0
• Component/s: common
• Assignee: Unassigned
• Reporter: Zhaobo Huang
• Created: 07/Jan/24 09:22
• Updated: 10/Jan/24 19:40
• Resolved: 09/Jan/24 02:19

Description

Change the judgment logic:
It is necessary to determine whether the effective is null, rather than newValue.

Because the parameter of the properties.set method is effective.

final String effective = reconfigureProperty(property, newValue);
LOG.info("{}: changed property {} to {} (effective {})", name, property, newValue, effective);
if (newValue != null) {
  properties.set(property, effective);
} else {
  properties.unset(property);
} 

Issue Links

• links to: GitHub Pull Request #1004