[RATIS-1916] OrderAsync does not call handReply

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0
• Component/s: client
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 23/Oct/23 18:23
• Updated: 25/Oct/23 15:10
• Resolved: 25/Oct/23 06:18

Description

In code below, the future f is always done so client.handleReply(..) is never called.

//OrderedAsync.sendRequestWithRetry(..)
    sendRequest(pending).thenAccept(reply -> {
      if (f.isDone()) {
        return;
      }
      if (reply == null) {
        scheduleWithTimeout(pending, request, retryPolicy, null);
      } else {
        client.handleReply(request, reply);
        f.complete(reply);
      }
    })...

Issue Links

• links to: GitHub Pull Request #948