[RATIS-1890] SegmentedRaftLogCache#shouldEvict should only iterate over closed segments once

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.0, 2.4.1, 2.5.0, 2.5.1
• Fix Version/s: 3.0.0
• Target Version/s: 2.5.2
• Assignee: Ivan Andika
• Reporter: Ivan Andika
• Created: 18/Sep/23 05:20
• Updated: 19/Sep/23 15:41
• Resolved: 19/Sep/23 15:40

Description

It's observed that `SegmentedLogCache#shouldEvict` iterate over the `closedSegments` twice:

• `LogSegmentList#countCached`
• `LogSegmentList#getTotalCacheSize`

We can improve this by iterating over the `closedSegments` once.

Issue Links

• links to: GitHub Pull Request #921