[RATIS-1872] HeartbeatAck use in-correct callId as minCallId

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.5.1
• Fix Version/s: 3.0.0, 2.5.2
• Component/s: Linearizable Read, server
• Assignee: Tsz-wo Sze
• Reporter: Yaolong Liu
• Created: 17/Aug/23 03:29
• Updated: 18/Aug/23 15:11
• Resolved: 18/Aug/23 14:50

Description

In https://issues.apache.org/jira/browse/RATIS-1663 we add callId to all appendLog reuest. When trigger heartbeat，we need the reply comes after the trigger as below.

private boolean isValid(AppendEntriesReplyProto reply) {
      if (reply == null || !reply.getServerReply().getSuccess()) {
        return false;
      }
      // valid only if the reply has a later call id than the min.
      return appender.getCallIdComparator().compare(reply.getServerReply().getCallId(), minCallId) >= 0;
    }

However，the minCallId is initialize when we get heartBeatAck，this is in correct. If the callId of our triggerHeartbeat is 10, the callId may increase to 20 while waiting for the reply, when we receive the reply, the minCallId is set to 20, and all heartbeat messages are considered invalid.

Issue Links

• links to: GitHub Pull Request #905