Uploaded image for project: 'Ratis'
  1. Ratis
  2. RATIS-1823

Improve error log in StreamObserverWithTimeout

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.5.0
    • gRPC, snapshot
    • None

    Description

      In StreamObserverWithTimeout's LOG, Request body is fully printed , e.g. https://github.com/apache/ratis/blob/d495846f0b754a67594cc48f5559ca36838fd700/ratis-grpc/src/main/java/org/apache/ratis/grpc/util/StreamObserverWithTimeout.java#L85.
      However, the installSnapshot requests are sometimes large and even reach multiple megabytes (maxChunkSize). Print the whole request is cpu-consuming and annoying.

      Attachments

        Issue Links

          Activity

            People

              szetszwo Tsz-wo Sze
              William Song Song Ziyang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 0.5h
                  0.5h