[RATIS-1782] gRPC installSnapshot timeout handler malfunctioning

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Duplicate
• Affects Version/s: 2.4.1
• Component/s: gRPC, snapshot
• Assignee: Xinyu Tan
• Reporter: Song Ziyang
• Created: 15/Feb/23 03:20
• Updated: 11/Aug/23 18:36
• Resolved: 11/Aug/23 18:36

Description

When gRPC logAppender fails to install a snapshot to a follower owing to timeout, the onError callback will be invoked and resetClient is called. However, in this resetClient[1] handler, installSnapshotResponseHandler is not set to null (compared to  appendLogReponseHandler). In this way, pending RPCs in the old installSnapshot pipe will timeout and call the onError again sometime in the future, disrupting future on-going installSnapshot requests.

[1] https://github.com/apache/ratis/blob/18eacaed31e4965a9c400d86409a88fea21fc18a/ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java#L117-L120

Issue Links

• duplicates: RATIS-1786 Reset the digester of the follower at the beginning of each file transfer during a InstallSnapshot to avoid snapshot transfer failure
• duplicates: RATIS-1812 Enforce a outstanding request limit in StreamObserverWithTimeout