Uploaded image for project: 'Ratis'
  1. Ratis
  2. RATIS-1742

Remove slf4j-log4j12 test dependency from ratis-common and ratis-server

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.0.0, 2.5.0
    • test
    • None

    Description

      For ratis-server, slf4j-log4j12 is unused so that it can be removed directly.

      For ratis-common, slf4j-log4j12 is only used in Slf4jUtils after RATIS-1728. We may use reflection to implement the setLevel method.

      We also fix the following test problems:

      • There is a "multiple SLF4J bindings" warning so ratis-test should exclude the slf4j-simple from ratis-shell.
      • The following deprecation warnings.
        [WARNING] /Users/szetszwo/ratis/apache-ratis/ratis-test/src/test/java/org/apache/ratis/server/raftlog/segmented/TestSegmentedRaftLog.java:[715,27] [deprecation] append(LogEntryProto...) in RaftLogSequentialOps has been deprecated
        [WARNING] /Users/szetszwo/ratis/apache-ratis/ratis-test/src/test/java/org/apache/ratis/datastream/TestDataStreamDisabled.java:[35,62] [deprecation] none() in ExpectedException has been deprecated
        

      Attachments

        Issue Links

          Activity

            People

              szetszwo Tsz-wo Sze
              szetszwo Tsz-wo Sze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m