[RATIS-1656] Leftover usage of ForkJoinPool.commonPool() in RaftServerImpl

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.4.0, 3.0.0
• Component/s: server
• Target Version/s: 2.4.0, 3.0.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 03/Aug/22 11:55
• Updated: 24/Feb/23 18:08
• Resolved: 07/Aug/22 06:28

Description

RaftServerImpl#appendEntriesAsync is still using the common pool here:

https://github.com/apache/ratis/blob/3db8f9eac82efedd51322a0d213300c9a0940bb6/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L1416-L1417

    return JavaUtils.allOf(futures).whenCompleteAsync(
        (r, t) -> followerState.ifPresent(fs -> fs.updateLastRpcTime(FollowerState.UpdateType.APPEND_COMPLETE))

I think it should be executed directly, since it's already executing on serverExecutor.

Issue Links

• fixes: RATIS-530 Avoid using common fork join pool
• is related to: RATIS-1503 Avoid using ForkJoinPool.commonPool() in RaftServerProxy/Impl
• relates to: RATIS-1792 Replace parallelStream usage in PeerProxyMap
• links to: GitHub Pull Request #702