[RATIS-1655] Fix OrderedStreamAsync#scheduleWithTimeout to report a correct timeout value

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.0, 3.0.0
• Fix Version/s: 2.4.0, 3.0.0
• Component/s: server
• Assignee: Kiyoshi Mizumaru
• Reporter: Kiyoshi Mizumaru
• Created: 02/Aug/22 18:18
• Updated: 16/Aug/22 16:34
• Resolved: 02/Aug/22 20:58

Description

While reading OrderedStreamAsync.java, I noticed that scheduleWithTimeout always reports the value of requestTimeout field wrapped in TimeoutIOException.

 

  private void scheduleWithTimeout(DataStreamWindowRequest request, TimeDuration timeout) {
    scheduler.onTimeout(timeout, () -> {
      if (!request.getReplyFuture().isDone()) {
        request.getReplyFuture().completeExceptionally(
            new TimeoutIOException("Timeout " + requestTimeout + ": Failed to send " + request));
      }
    }, LOG, () -> "Failed to completeExceptionally for " + request);
  }

I think this should be timeout, which passed in the following call:

    final boolean isClose = StandardWriteOption.CLOSE.isOneOf(request.getDataStreamRequest().getWriteOptions());
    scheduleWithTimeout(request, isClose? closeTimeout: requestTimeout); 

What do you think?

 

Issue Links

• links to: GitHub Pull Request #701