[RATIS-1447] Cleanup NettyClientStreamRpc#replies empty queue

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.3.0
• Component/s: Netty, Streaming
• Assignee: GuoHao
• Reporter: GuoHao
• Created: 29/Nov/21 12:48
• Updated: 01/Dec/21 12:54
• Resolved: 01/Dec/21 12:54

Description

org.apache.ratis.netty.client.NettyClientStreamRpc#replies

private final ConcurrentMap<ClientInvocationId, Queue<CompletableFuture<DataStreamReply>>> replies =
      new ConcurrentHashMap<>();

When all data for a streamID has been sent, is it necessary to clear the queue from the map？

I would implement a ExpiringMap. If you don't use it for a long time or Queue.size is 0, I delete it from the Map.

Issue Links

• links to: GitHub Pull Request #542