[RATIS-135] Closed segments contribute to leaked memory as eviction policies are not honoured

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.2.0
• Assignee: Mukul Kumar Singh
• Reporter: Mukul Kumar Singh
• Created: 06/Nov/17 04:53
• Updated: 09/Nov/17 00:28
• Resolved: 09/Nov/17 00:28

Description

Closed segments leak memory as eviction does not remove these segments from closed segments list.

 void evictCache(long[] followerIndices, long flushedIndex,
      long lastAppliedIndex) {
    List<LogSegment> toEvict = evictionPolicy.evict(followerIndices,
        flushedIndex, lastAppliedIndex, closedSegments, maxCachedSegments);
    for (LogSegment s : toEvict) {
      s.evictCache();
    }

After the segments have been marked for eviction, they should be removed from queue as well.