[RATIS-1306] Eliminate duplicated GitHub Actions workflow

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: build
• Target Version/s: 2.0.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 04/Feb/21 11:58
• Updated: 08/Feb/21 08:47
• Resolved: 04/Feb/21 23:48

Description

GitHub Actions workflows for Ratis CI have two flavors: post-commit and pull-request. The main difference between the two is that Sonar is not updated for PRs:

-        - run: ./dev-support/checks/sonar.sh
-          if: github.repository == 'apache/incubator-ratis'
-          env:
-            SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }}
-            GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Similar to HDDS-3822, we can keep only the post-commit definition and execute sonar.sh conditionally.

The other difference is missing Summary of failures in the post-commit workflow, but it can be added.

Issue Links

• links to: GitHub Pull Request #415