[RATIS-1210] Expose RetryCache

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: server
• Assignee: Tsz-wo Sze
• Reporter: Bharat Viswanadham
• Created: 06/Dec/20 18:04
• Updated: 19/Oct/24 03:41
• Resolved: 08/Dec/20 05:28

Description

In OM HA to support upgrades with out any additional steps like prepareUpgrade for express upgrade, a new proposal is coming up to change in the way request is processed and also in the future to support rolling upgrades. In the previous approach request logic is executed by the leader/follower OMs.

In the new approach, only leader OM processes the request and submits only the information which needs to be persisted to DB to ratis. So, with this approach after isLeaderReady() check, we first need to check retry cache to see if this is a retry request before processing the request in OM for idempotency/correctness.

This Jira is to propose to expose retry cache and also expose a method to just query retry cache. As current queryCacheResult, if not exists, adds a new entry to cache.

Scenario:
Leader processed the request and submitted to OM, leader adds to it log, and send to followers, just before applyTransaction leader change happened. In ratis all pending requests are responded with NotLeaderException. So, when the new OM before becoming ready, it should process all the requests, as the previous transaction is in majority this transaction will be applied by new leader OM and then becomes ready. So, when the client retries on new OM with same clientID and callID OM leader before processing it should detect is retry request for that it needs to check ratis retry cache.

Issue Links

• is related to: HDDS-11418 Leader executor framework
• links to: GitHub Pull Request #334