Uploaded image for project: 'Ratis'
  1. Ratis
  2. RATIS-1102

Fix typo in MetricRegistriesImpl#create warning message

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • metrics
    • None

    Description

      The warning message in MetricRegistriesImpl#create should read addReport*er*Registration. It was missing the "er". It confused me for a bit when I'm trying to follow the message.

        @Override
        public RatisMetricRegistry create(MetricRegistryInfo info) {
          return registries.put(info, () -> {
            if (reporterRegistrations.isEmpty()) {
              LOG.warn(
                  "First MetricRegistry has been created without registering reporters. You may need to call" +
                      " MetricRegistries.global().addReporterRegistration(...) before.");
            }
            RatisMetricRegistry registry = factory.create(info);
            reporterRegistrations.forEach(reg -> reg.accept(registry));
            return registry;
          });
        }
      

      Attachments

        Issue Links

          Activity

            People

              smeng Siyao Meng
              smeng Siyao Meng
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 50m
                  1h 50m