[RAT-369] Add SpotBugs and checkstyle to the pom files. - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 0.17
Component/s: Client - ant, Client - cli, Client - maven, core engine
Labels:
None

Description

Currently we have a number of issues that Spotbugs will detect. I ran a quick test this afternoon and it found 60 potential bugs. This ticket is to add spotbugs to the maven build, ensure that no bugs are found and ensure that the build will fail if bugs are found.

Add checkbugs as well.

As most of the reported errors cannot be fixed with JDK8, add exclusions for these "old"/JDK8-classes that do not allow to set a proper encoding, thus relying on the default system encoding!