Uploaded image for project: 'Apache Rat'
  1. Apache Rat
  2. RAT-362

plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 0.16.1
    • 0.17
    • None
    • None

    Description

      When I have a Maven project checked out in the directory '/foo', and I have a file called 'foo.md' in the root of that project, ignoring it by putting a '/foo.md' entry in the .gitignore file does not work.

      It is unclear whether this is an issue in the plugin or in de codeowners gitignore-reader dependency: the plugin is passing relative filenames (i.e. 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method don't make it too clear whether that is intended to accept absolute filenames, relative filename, or both.

      In this scenario, it seems to take the relative filename 'foo.md' and remove the project base directory '/foo' from it, leaving '/.md' (which then of course does not match the 'foo.md' from the .gitignore).

      Attachments

        Issue Links

          Activity

            People

              pottlinger Philipp Ottlinger
              engelen Arnout Engelen
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: