[RAT-362] plugin: .gitignore not correctly applied - bugfix in underlying gitignore-reader library

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.16.1
• Fix Version/s: 0.17
• Assignee: Philipp Ottlinger
• Reporter: Arnout Engelen
• Created: 05/Feb/24 12:21
• Updated: 25/Mar/24 12:16
• Resolved: 23/Mar/24 21:55

Description

When I have a Maven project checked out in the directory '/foo', and I have a file called 'foo.md' in the root of that project, ignoring it by putting a '/foo.md' entry in the .gitignore file does not work.

It is unclear whether this is an issue in the plugin or in de codeowners gitignore-reader dependency: the plugin is passing relative filenames (i.e. 'foo.md') to GitIgnoreFileSet#isIgnoredFile , but the API docs on that method don't make it too clear whether that is intended to accept absolute filenames, relative filename, or both.

In this scenario, it seems to take the relative filename 'foo.md' and remove the project base directory '/foo' from it, leaving '/.md' (which then of course does not match the 'foo.md' from the .gitignore).

Issue Links

• links to: GitHub Pull Request #229