[RAT-246] .gitignore in parent dir not honored

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12, 0.13
• Fix Version/s: 0.17
• Assignee: Claude Warren
• Reporter: Ilya Basin
• Created: 09/Feb/18 08:43
• Updated: 23/Nov/24 20:13
• Resolved: 13/Nov/24 22:56

Description

Due to my Eclipse plugins set, when I import a maven project, a .checkstyle file is generated there. As I learned later, RAT 0.13-SNAPSHOT ignores .checkstyle files, so I repeated my tests with a different filename.

If a pattern is explicitly mentioned in the .gitignore in the project folder, RAT does not complain. However, if the pattern is only mentioned in a parent .gitignore, the RAT check fails.

[il@reallin wagon-scm]$ touch .someignoredfile
[il@reallin wagon-scm]$ echo .someignoredfile >>../../.gitignore

[il@reallin wagon-scm]$ git add .someignoredfile
The following paths are ignored by one of your .gitignore files:
wagon-providers/wagon-scm/.someignoredfile
Use -f if you really want to add them.
fatal: no files added

[il@reallin wagon-scm]$ mvn apache-rat:check
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project wagon-scm: Too many files with unapproved license: 1 See RAT report in: target/rat.txt -> [Help 1]

[il@reallin wagon-scm]$ cat target/rat.txt
Files with unapproved licenses:

  .someignoredfile

[il@reallin wagon-scm]$ echo .someignoredfile >>.gitignore

[il@reallin wagon-scm]$ mvn apache-rat:check
[INFO] BUILD SUCCESS

Issue Links

• is blocked by: RAT-399 Migrate ignore errors functionality from Maven module
• relates to: RAT-171 Allow exclude patterns to be read from a file or files
• links to: GitHub Pull Request #390