[RAT-162] CDDL1License.matches slow with large inputs

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.10
• Fix Version/s: 0.11
• Assignee: Philipp Ottlinger
• Reporter: Andrew Gaul
• Created: 10/Jun/14 21:11
• Updated: 04/Oct/14 10:35
• Resolved: 23/Jul/14 21:50

Description

mvn apache-rat:check runs slowly with large files. I accidentally had a 100 MB log file which took over a minute to for RAT to parse. The stack trace included:

"main" prio=10 tid=0x00007f322800a000 nid=0x6730 runnable [0x00007f3230235000]
   java.lang.Thread.State: RUNNABLE
        at java.util.regex.Pattern$Curly.match0(Pattern.java:4166)
        at java.util.regex.Pattern$Curly.match(Pattern.java:4132)
        at java.util.regex.Pattern$Start.match(Pattern.java:3408)
        at java.util.regex.Matcher.search(Matcher.java:1199)
        at java.util.regex.Matcher.find(Matcher.java:592)
        at org.apache.rat.analysis.license.CDDL1License.matches(CDDL1License.java:65)
        at org.apache.rat.analysis.license.SimplePatternBasedLicense.match(SimplePatternBasedLicense.java:69)

I attached a patch which caches the Patterns in CDDL1License which works around this issue.

Issue Links

• relates to: RAT-174 CDDL1License still very slow