[RAT-148] LicenseAddingReport#report has useless call to metaData.getData

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.11
• Component/s: reports
• Assignee: Philipp Ottlinger
• Reporter: Chris A. Mattmann
• Created: 29/Aug/13 04:27
• Updated: 25/Jul/14 14:37
• Resolved: 23/Jul/14 22:04

Description

While perusing the current trunk code, I noticed that LicenseAddingReport.java#report has a useless call to metaData.getData:

public class LicenseAddingReport extends AbstractReport {
    private final AbstractLicenceAppender appender;

    public LicenseAddingReport(String pCopyrightMsg, boolean pForced) {
        appender = pCopyrightMsg == null ? new ApacheV2LicenceAppender() : new ApacheV2LicenceAppender(pCopyrightMsg);
        appender.setForce(pForced);
    }

    @Override
    public void report(org.apache.rat.api.Document document) throws RatException {
        final MetaData metaData = document.getMetaData();
        final Datum licenseHeader = metaData.get(MetaData.RAT_URL_HEADER_CATEGORY);
        if (licenseHeader == null
                ||  MetaData.RAT_LICENSE_FAMILY_CATEGORY_DATUM_UNKNOWN.getValue().equals(licenseHeader.getValue())) {
            final File file = new File(document.getName());
            if (file.isFile()) {
                try {
                    appender.append(file);
                } catch (IOException e) {
                    throw new RatException(e.getMessage(), e);
                }
            }
        }
        metaData.getData();
    }
}

Looks to me that metaData is a local final variable, and that the call to getData returns a MetaData object, which in turn is never used.