Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.0.0
    • 3.0.0, 2.5.0
    • Ranger
    • None

    Attachments

      Activity

         

        commit 085baf44248a3167f0d668b410626bc91fc1184c (HEAD -> master, origin/master, origin/HEAD)
        Author: Pradeep AgrawaL <pradeep@apache.org>
        Date:   Tue Jul 16 11:52:32 2024 +0530
        
            RANGER-4859: updated Trino service-def for authorization interface changes in Trino 451
             - removed Trino plugin implementation as it is being moved into Trino repo
        
            Signed-off-by: Madhan Neethiraj <madhan@apache.org>
        

         

        commit 3436c25174ccf4c508c80f270df5a3f11c5e0d90 (HEAD -> ranger-2.5, origin/ranger-2.5)
        Author: Pradeep AgrawaL <pradeep@apache.org>
        Date:   Tue Jul 16 11:52:32 2024 +0530
        
            RANGER-4859: updated Trino service-def for authorization interface changes in Trino 451
             - removed Trino plugin implementation as it is being moved into Trino repo
        
            Signed-off-by: Madhan Neethiraj <madhan@apache.org>
            (cherry picked from commit 085baf44248a3167f0d668b410626bc91fc1184c)
        
        madhan Madhan Neethiraj added a comment -   commit 085baf44248a3167f0d668b410626bc91fc1184c (HEAD -> master, origin/master, origin/HEAD) Author: Pradeep AgrawaL <pradeep@apache.org> Date: Tue Jul 16 11:52:32 2024 +0530 RANGER-4859: updated Trino service-def for authorization interface changes in Trino 451 - removed Trino plugin implementation as it is being moved into Trino repo Signed-off-by: Madhan Neethiraj <madhan@apache.org>   commit 3436c25174ccf4c508c80f270df5a3f11c5e0d90 (HEAD -> ranger-2.5, origin/ranger-2.5) Author: Pradeep AgrawaL <pradeep@apache.org> Date: Tue Jul 16 11:52:32 2024 +0530 RANGER-4859: updated Trino service-def for authorization interface changes in Trino 451 - removed Trino plugin implementation as it is being moved into Trino repo Signed-off-by: Madhan Neethiraj <madhan@apache.org> (cherry picked from commit 085baf44248a3167f0d668b410626bc91fc1184c)
        bpatel Bhavik Patel added a comment -

        Madhan Neethiraj I think patch is not completed yet. As JAVA patch number 61 is mentioned in the schema file but actual class file is not present in the patch.

        bpatel Bhavik Patel added a comment - Madhan Neethiraj I think patch is not completed yet. As JAVA patch number 61 is mentioned in the schema file but actual class file is not present in the patch.
        pradeep Pradeep Agrawal added a comment - - edited

        Bhavik Patel : Are you saying this file is not present in the ranger branch/repo :

        https://github.com/apache/ranger/blob/master/security-admin/src/main/java/org/apache/ranger/patch/PatchSetAccessTypeCategory_J10061.java

        I added the entry because it was missing from earlier work.

        pradeep Pradeep Agrawal added a comment - - edited Bhavik Patel : Are you saying this file is not present in the ranger branch/repo : https://github.com/apache/ranger/blob/master/security-admin/src/main/java/org/apache/ranger/patch/PatchSetAccessTypeCategory_J10061.java I added the entry because it was missing from earlier work.
        bpatel Bhavik Patel added a comment -

        ohh ok.

        Thanks Pradeep Agrawal for the clarification.

        bpatel Bhavik Patel added a comment - ohh ok. Thanks Pradeep Agrawal for the clarification.
        zhongwei11 wangzhongwei added a comment - - edited

        Madhan Neethiraj Hi sir, I used trino version 406,enable trino plugin and restart trino  coordinator , There was an error that the TrinoRangerPlugin  not found. I found that this patch delete the class .  Does the configuration need to be changed after merging this patch?

        org.apache.ranger.authorization.trino.authorizer.TrinoRangerPlugin  referred in plugin-trino/src/main/resources/META-INF/services/io.trino.spi.Plugin

        zhongwei11 wangzhongwei added a comment - - edited Madhan Neethiraj Hi sir, I used trino version 406,enable trino plugin and restart trino  coordinator , There was an error that the TrinoRangerPlugin  not found. I found that this patch delete the class .  Does the configuration need to be changed after merging this patch? org.apache.ranger.authorization.trino.authorizer.TrinoRangerPlugin  referred in plugin-trino/src/main/resources/META-INF/services/io.trino.spi.Plugin

        wangzhongwei  - Trino plugin implementation was removed from Ranger git repo in 2.5.0 release and is being moved into Trino git repo - see pull request #22675. If you would need to use earlier version of Trino plugin from Ranger git repo, consider compiling it from ranger-2.4 branch.

        madhan Madhan Neethiraj added a comment - wangzhongwei   - Trino plugin implementation was removed from Ranger git repo in 2.5.0 release and is being moved into Trino git repo - see pull request #22675 . If you would need to use earlier version of Trino plugin from Ranger git repo, consider compiling it from ranger-2.4 branch .
        zhongwei11 wangzhongwei added a comment -

        Madhan Neethiraj I see, thanks for the answer

        zhongwei11 wangzhongwei added a comment - Madhan Neethiraj I see, thanks for the answer

        People

          pradeep Pradeep Agrawal
          pradeep Pradeep Agrawal
          Votes:
          0 Vote for this issue
          Watchers:
          Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Time Tracking

            Estimated:
            Original Estimate - Not Specified
            Not Specified
            Remaining:
            Remaining Estimate - 0h
            0h
            Logged:
            Time Spent - 0.5h
            0.5h

            Slack