[RANGER-3386] apache CollectionUtils package reduce ranger agent performance and should be replaced

• Type: Improvement
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.0.1
• Component/s: plugins
• Assignee: caozhiqiang
• Reporter: caozhiqiang
• Created: 29/Aug/21 15:40
• Updated: 10/Sep/21 10:34

Description

org.apache.commons.collections.CollectionUtils' performance is too poor and reduce the performance of ranger plugins, particularly with hdfs. There are too many places used CollectionUtils.isNotEmpty and CollectionUtils.isEmpty in agent component, so we should replace them.

We can see many CollectionUtils call is take too much time in namenode benchmark's result.

In this patch, I replace almost CollectionUtils functions in agents-common. After adding this patch, in creating file benchmark of hdfs, the performance can improve from creating 7000 files to 7600 files per second.

By the way, I write a simple test code below. collection.isEmpty is almost take 0 milliseconds, but CollectionUtils.isNotEmpty take 5 milliseconds.

 

List<Integer> list = new ArrayList<Integer>();
for(int i = 0; i<1000; i++)
    list.add(i);

long startTime = System.currentTimeMillis();
if(list != null && !list.isEmpty()){

}
long endTime   = System.currentTimeMillis();
long totalTime = endTime - startTime;
System.out.println(totalTime);


long startTime2 = System.currentTimeMillis();
CollectionUtils.isNotEmpty(list);
long endTime2   = System.currentTimeMillis();
long totalTime2 = endTime2 - startTime2;
System.out.println(totalTime2);

 

Issue Links

• is related to: RANGER-3406 apache CollectionUtils package reduce ranger agent performance