[RANGER-1991] Fix problems detected by static code analysis

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.7.1
• Fix Version/s: 1.0.0
• Component/s: admin
• Labels: code-cleanup findbugs
• Flags: Patch
• Assignee: Zsombor Gegesy
• Reporter: Zsombor Gegesy
• Created: 24/Feb/18 16:12
• Updated: 14/Mar/18 20:54
• Resolved: 13/Mar/18 01:53

Description

FindBugs/SpotBug detects a couple of problems with the code base:

• Incorrect class casting - in XXServiceDef.equals
• Unnecessary NPE checks - for variables which is known to be non-null (for example, because in other places a method is called on that object). In ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in XUserMgr.java

• Collection.contains method call which is never true - in ServiceDBStore.validatePolicyItems for policyItem.getAccesses().contains("") - because getAccesses doesn't store String objects
• Making public partially initialized objects in HadoopConfigHolder.initResourceMap()
• Calling toString on array, which is not too readable

 

Issue Links

• causes: RANGER-2016 Fix null passed in as a HttpServletRequest - into the deletePoliciesProvidedInServiceMap method.
• links to: Review link