[RANGER-1859] Fix new findBugs in HdfsClient.java - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 1.0.0
Fix Version/s: 1.0.0, master
Component/s: admin
Labels:
- findbugs
- patch

Flags:

Patch, Important

Description

There is FindBugs: Performance (FB.SBSC_USE_STRINGBUFFER_CONCATENATION) in org.apache.ranger.services.hdfs.client.HdfsClient.validateConnectionConfigs(Map<String, String>)

if (fsDefaultNameElements != null && fsDefaultNameElements.length >= 2) {
	String cluster = "";
	StringBuffer clusters = new StringBuffer();
	configs.put("dfs.nameservices", "hdfscluster");
	configs.put("fs.default.name", "hdfs://" + configs.get("dfs.nameservices"));
	configs.put("dfs.client.failover.proxy.provider." + configs.get("dfs.nameservices"),
			"org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider");
	for (int i = 0; i < fsDefaultNameElements.length; i++) {
		cluster = "namenode" + (i + 1);
		configs.put("dfs.namenode.rpc-address." + configs.get("dfs.nameservices") + "." + cluster,
				fsDefaultNameElements[i]);
		if (i == (fsDefaultNameElements.length - 1)) {
				clusters.append(cluster);
		} else {
				clusters.append(cluster).append(",");
		}
	}
	configs.put("dfs.ha.namenodes." + configs.get("dfs.nameservices"), clusters.toString());
}