Uploaded image for project: 'Ranger'
  1. Ranger
  2. RANGER-1349

Code block was iterated four times, in fact it should only be executed once during initializing InitD for ranger usersync process

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.7.0
    • usersync
    • Patch

    Description

      There is logical error during initialize InitD for ranger usersync process. The following code block will be iterated four times. It's reasonable to execute once.
      From following code we can seen that the code block from userSyncScriptName = "ranger-usersync-services.sh" to os.symlink(localScriptName,ubinScriptName) was iterated four times. It only needs be executed one. The error reason is that developer ignores python block syntax.
      for rcDir in rcDirList:
      if (os.path.isdir(rcDir)):
      for prefix in initPrefixList:
      scriptFn = prefix + initdProgramName
      scriptName = join(rcDir, scriptFn)
      if isfile(scriptName) or os.path.islink(scriptName):
      os.remove(scriptName)
      os.symlink(initdFn,scriptName)
      userSyncScriptName = "ranger-usersync-services.sh"
      localScriptName = os.path.abspath(join(installPropDirName,userSyncScriptName))
      ubinScriptName = join("/usr/bin",initdProgramName)
      if isfile(ubinScriptName) or os.path.islink(ubinScriptName):
      os.remove(ubinScriptName)
      os.symlink(localScriptName,ubinScriptName)

      Attachments

        Activity

          People

            zhangqiang2 Qiang Zhang
            zhangqiang2 Qiang Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: