[QPIDJMS-572] The internal Netty ReadableBuffer wrapper read string API not advancing position index

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.6.0, 2.0.0
• Fix Version/s: 1.7.0, 2.1.0
• Component/s: qpid-jms-client
• Assignee: Timothy A. Bish
• Reporter: Timothy A. Bish
• Created: 07/Jul/22 19:02
• Updated: 20/Sep/22 15:53
• Resolved: 07/Jul/22 19:09

Description

The ReadableBuffer API from proton-j provides methods for reading a string from the remaining readable bytes in the buffer and documents these methods should advance the read index to the limit on return.  The Qpid JMS readable buffer isn't advancing the position as it passes the decoding off to a Netty toString call which does not advance the read index.  This is masked in proton-j currently as all string decodes are done from slices of a buffer or in some cases a duplicate and the buffer slice is cast off afterwards without care for any remaining bytes. Should proton-j be updated to not rely on slices for every single string decode this breaks the codec.