[QPIDJMS-544] JmsDefaultPrefetchPolicy#getMaxPrefetchLimit logs incorrect MAX_PREFETCH_SIZE

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.0.0, 1.1.0
• Fix Version/s: 1.2.0, 0.60.1
• Component/s: qpid-jms-client
• Assignee: Robbie Gemmell
• Reporter: Alexander Scott
• Created: 26/Jul/21 04:59
• Updated: 14/Dec/21 17:48
• Resolved: 14/Dec/21 17:47

Description

When using the `JmsDefaultPrefetchPolicy` and setting a prefetch limit, prefetch values greater than the `maxPrefetchSize` are logged as being reset to the `MAX_PREFETCH_SIZE`. I believe `MAX_PREFETCH_SIZE` should be changed to `maxPrefetchSize`.

 

 

private int getMaxPrefetchLimit(int value) {
    int result = Math.min(value, maxPrefetchSize);
    if (result < value) {
        LOG.warn("maximum prefetch limit has been reset from " + value + " to " + MAX_PREFETCH_SIZE);
    }
    return result;
}

 

 

private int getMaxPrefetchLimit(int value) {
    int result = Math.min(value, maxPrefetchSize);
    if (result < value) {
        LOG.warn("maximum prefetch limit has been reset from " + value + " to " + maxPrefetchSize);
    }
    return result;
}