[QPIDJMS-530] Potential NPE in JmsSession consumerClosed()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.56.0
• Fix Version/s: 0.58.0
• Assignee: Timothy A. Bish
• Reporter: David Martin
• Created: 29/Mar/21 14:39
• Updated: 13/Apr/21 11:31
• Resolved: 29/Mar/21 16:23

Description

In the following code (JMSSession line 416), if consumer is null this throws a NPE and the consumer never recovers:

        JmsMessageConsumer consumer = consumers.get(resource.getId());
        if (consumer.hasMessageListener()) {
            connection.onAsyncException(JmsExceptionSupport.create(cause));
        }

        try {
            if (consumer != null) {
                consumer.shutdown(cause);
            }

Happy to raise a PR myself for this (just ask) but I have had to fix it locally.