[QPIDJMS-481] improve handling of transport/decode errors and better signal failure cause

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.47.0
• Fix Version/s: 0.48.0
• Component/s: qpid-jms-client
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 25/Nov/19 12:06
• Updated: 29/Jan/20 13:45
• Resolved: 25/Nov/19 12:10

Description

When a decode exception happens in the proton transport while decoding incoming frames, proton closes the transport and emits a close frame (typically causing a response close to be sent) but the client itself is essentially unaware until later. An example of this was seen while identifying DISPATCH-1488 recently.

If the response close (or other data) arrives, the client tries to process the proton transport with the data, which throws due to its input already being closed. This triggers the connection failure handling and provokes a stack trace in the logs, but neither gives much helpful info about the cause of the overall situation, simply referring to the resulting 'tail closed' situation.

PROTON-2142 fixes the proton-j handling to ensure the close frame emitted actually contains a decode error giving some indication of what actually lead to the closure. The client should also look to handle this situation better itself though, using notice of the transport decode error occurring to trigger its failure handling directly with the error detail noted as the failure cause, and skip further input processing.

Issue Links

• relates to: DISPATCH-1488 link-routed transaction coordination broken due to 'declared' state truncation
• relates to: PROTON-2142 transports closed due to decode error may emit a close frame without error condition
• relates to: QPIDJMS-482 update to proton-j 0.33.3