[QPIDJMS-454] explicitly populate the durable field if already sending a Header section

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 0.42.0
• Component/s: qpid-jms-client
• Assignee: Robbie Gemmell
• Reporter: Robbie Gemmell
• Created: 07/May/19 11:39
• Updated: 10/May/19 17:16
• Resolved: 07/May/19 15:29

Description

Once it becomes necessary to actually send a Header section for a non-persistent message, e.g. because a later priority/ttl/etc field is set, populate its durable field false explicitly since defaulting it no longer nets a strict benefit.

(The existing 0.41.0 behaviour is perfectly legal and NOT a bug, but restoring this behaviour of <=0.11.1 will help people upgrading from <=0.11.1 to a 0.20.0+ release avoid hitting AMQ-7189 in ActiveMQ 5 releases prior to 5.15.10, which is not yet released at time of writing. More background:
https://lists.apache.org/thread.html/cf8d0f0ca6b232a8a447d984b27edc0fe58a7cc2e5a76f8c7e5e6cca@%3Cusers.qpid.apache.org%3E)