[QPID-8667] [Broker-J] Database connection with client certificate authentication exposes keystore / truststore passwords

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: qpid-java-broker-9.1.0
• Fix Version/s: qpid-java-broker-9.2.0
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Daniil Kirilyuk
• Created: 24/Jan/24 09:13
• Updated: 12/Feb/24 10:00
• Resolved: 29/Jan/24 12:51

Description

JDBC allows to supply datasource parameters via JDBC connection string in form: jdbc:<vendor>://<hostname>:<port>/<database>?key1=value1&key2=value2&key3=value3

Relevant configuration for a virtualhost for PostgreSQL looks like following:

{
  "type" : "JDBC",
  "connectionPoolType" : "BONECP",
  "connectionUrl": "jdbc:postgresql://<hostname>:<port>/<database_name>?ssl=true&sslmode=verify-full&sslkey=<path_to_ssl_key_file>&sslpassword=<ssl_key_file_password>&sslrootcert=<path_to_root_certificate>",
  "username": "QPID",
  "password": null
} 

To make hide sensitive parameters like keystore / truststore passwords configuration should reference a keystore or truststore instead providing the RDBMS-specific parameter names:

{
  "name" : "default",
  "type" : "JDBC",
  "connectionPoolType" : "BONECP",
  "connectionUrl" : "jdbc:postgresql://<hostname>:<port>/<database_name>?ssl=true&sslmode=verify-full&sslrootcert=<path_to_root_certificate>",
  "keyStore" : "keystore-database",
  "keyStorePasswordPropertyName" : "sslpassword",
  "keyStorePathPropertyName" : "sslkey",
  "trustStore" : null,
  "trustStorePasswordPropertyName" : null,
  "trustStorePathPropertyName" : null,
  "username" : "QPID"
}

Here keystore "keystore-database" is referenced, containing path to the keystore as well as its password (which is hidden). Path to the keystore should be injected into the JDBC connection string using the parameter "keyStorePathPropertyName", keystores password should be injected into JDBC connection string using the parameter "keyStorePasswordPropertyName".