[QPID-8549] [Broker-J] HP Fortify: Null de-reference

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: qpid-java-broker-8.0.5
• Fix Version/s: qpid-java-broker-9.0.0
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Daniil Kirilyuk
• Created: 08/Jul/21 09:54
• Updated: 11/Nov/22 12:22
• Resolved: 25/Jul/21 17:41

Description

HP Fortify complains about several places where a null might get de-referenced:

broker-core/src/main/java/org/apache/qpid/server/transport/MultiVersionProtocolEngine.java
467 - Assigned null : supportedReplyVersion
Can be refactored to String.valueOf()
469 - Dereferenced : supportedReplyBytes

broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/AMQPConnection_1_0Impl.java
957 - Dereferenced : soleConnectionEnforcementPolicy
968 - Dereferenced : soleConnectionEnforcementPolicy

broker-core/src/main/java/org/apache/qpid/server/consumer/AbstractConsumerTarget.java
282 - Dereferenced : consumer

broker-core/src/main/java/org/apache/qpid/server/queue/SortedQueueEntryList.java
113 - Dereferenced : parent
122 - Dereferenced : parent

tools/src/main/java/org/apache/qpid/tools/StressTestClient.java
409 - Dereferenced : consumer

tools/src/main/java/org/apache/qpid/tools/util/ArgumentsParser.java
166 - Dereferenced : defaultValue

broker-plugins/amqp-1-0-protocol/src/main/org/apache/qpid/server/protocol/v1_0/ConsumerTarget_1_0.java
489 - Dereferenced : txn
508 - Dereferenced : txn
536 - Dereferenced : txn
557 - Dereferenced : txn
592 - Dereferenced : txn

bdbstore/src/main/java/org/apache/qpid/server/store/berkeleydb/BDBConfiguredObjectRecord.java
114 - Dereferenced :

broker-plugins/amqp-1-0-protocol/src/main/java/org/apache/qpid/server/protocol/v1_0/MessageConverter_from_1_0.java
92 - Dereferenced : sections

broker-core/src/main/java/org/apache/qpid/server/queue/DefinedGroupMessageGroupManager.java

259 - Dereferenced : messageHeader
260 - Dereferenced : messageHeader