Uploaded image for project: 'Qpid'
  1. Qpid
  2. QPID-8534

[Broker-J] Improper interruption of connection processing loop

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Broker-J

      Description

      The network connection scheduler (NetworkConnectionScheduler class) contains a thread pool. IO-threads are polling jobs from the scheduler work queue and executing them. The connection job works in the loop. The loop is interrupted when there is not any data to process or all IO-threads are occupied.

      If the loop is interrupted then the IO-thread pushes the connection job back into the queue and picks the next job from the queue. It should ensure that any job is not abandoned and it is not waiting in the queue for ever.
      But when the number of jobs equals to the thread pool size then IO-thread stops processing the connection job, pushes it back into the queue and polls the same job again, again and again.

      The connection job could check whether is there any job in the scheduler queue. If the queue was not empty then the connection working loop would be interrupted and the thread could pick up another job. It would simplified the broker code significantly.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              lacam Marek Laca
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: