[QPID-8223] [Broker-J] [AMQP 1.0] Broker can stop delivering messages when sending link delivery-count value exceeds Integer.MAX_VALUE, wraps around and turns negative

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: qpid-java-broker-7.0.3, qpid-java-broker-7.0.2, qpid-java-broker-7.0.0, qpid-java-broker-7.0.1, qpid-java-broker-7.0.4, qpid-java-broker-7.0.5, qpid-java-broker-7.0.6
• Fix Version/s: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
• Component/s: Broker-J
• Assignee: Alex Rudyy
• Reporter: Alex Rudyy
• Created: 05/Aug/18 20:00
• Updated: 05/Jan/19 20:01
• Resolved: 07/Aug/18 11:17

Description

The value of delivery-count is conceptually unbounded but it is encoded as a 32-bit
integer that wraps around and compares according to RFC-1982 serial number arithmetic. Broker-J does not handle the case of "negative credit" on a link correctly. For example, if deliver count is -1 and credit is 1, then limit would calculate as 0 and broker would stop sending messages