[QPID-8187] Incompatible callback function pointer casts fail to build on GCC 8

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: qpid-cpp-1.38.0
• Fix Version/s: qpid-cpp-1.39.0
• Component/s: C++ Broker

Environment

Gentoo x64, GCC 8.1

• Assignee: Justin Ross
• Reporter: Chris Richardson
• Created: 10/May/18 09:56
• Updated: 14/Dec/19 23:29
• Resolved: 21/Oct/18 21:47

Description

[ 22%] Building CXX object src/CMakeFiles/qpidcommon.dir/qpid/sys/epoll/EpollPoller.cpp.o
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp: In constructor ‘qpid::CyrusSasl::CyrusSasl(const string&, const string&, const string&, const string&, int, int, bool)’:
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:215:46: error: cast between incompatible function types from ‘int (void*, int, const char*, unsigned int)’ to ‘int ()’ [-Werror=cast-function-type]
callbacks[i].proc = (CallbackProc*) &getUserFromSettings;
^~~~~~~~~~~~~~~~~~~
/home/chrisr/projects/qpid/qpid-cpp/source/src/qpid/SaslFactory.cpp:223:50: error: cast between incompatible function types from ‘int (sasl_conn_t*, void*, int, sasl_secret_t**)’
Unknown macro: {aka ‘int (sasl_conn*, void*, int, sasl_secret**)’}
to ‘int ()’ [-Werror=cast-function-type]
callbacks[i].proc = (CallbackProc*) &getPasswordFromSettings;
^~~~~~~~~~~~~~~~~~~~~~ 

Given the constrains of the SASL library interface, the only obvious solution for this I can think of is to add "-Wno-error=cast-function-type" to the compiler settings.

Issue Links

• links to: GitHub Pull Request #17
• links to: GitHub Pull Request #17