[QPID-7958] [Java Broker] [AMQP0-10] References to messages sent by $virtualhostProperties node retained by store

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: qpid-java-broker-7.0.0
• Fix Version/s: qpid-java-broker-7.0.0
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Keith Wall
• Created: 05/Oct/17 16:08
• Updated: 14/Nov/17 22:01
• Resolved: 09/Oct/17 13:28

Description

On the 0-10 path, I notice that references to messages created by the ${virtualhostProperties} node are being retained internally within the store. This is leaking approximately ~1024 bytes per connection. Restarting the Broker or recycling the virtualhost frees the memory.

The reference are being retained by the AbstractXXXMessageStore#_messages set.

QPID-7783 added the _messages data structure. It was back ported to 6.0 and 6.1, so the leak might be present there too. I have not verified this. (updated 2017/10/06 does not affect 6.1 or 6.0. The MessageInstanceConsumerPair, which is no longer on master, unconditionally took a reference, so a reference was already taken).