[QPID-7899] [Java 0-8...0-9-1 Client] Message#setJMSCorrelationIDAsBytes() erroneously converts the bytes to string

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: qpid-java-client-0-x-6.3.0
• Component/s: JMS AMQP 0-x
• Assignee: Unassigned
• Reporter: Lorenz Quack
• Created: 25/Aug/17 08:19
• Updated: 22/Nov/17 09:30
• Resolved: 13/Nov/17 13:24

Description

The client converts the byte[] passed in to javax.jms.Message#setJMSCorrelationIDAsBytes to a String via new String(bytes);.
If the bytes are not the encoding of a String in the current default encoding (in which case why would you use this method in the first place), this is wrong.
In the JMS API implementation of setJMSCorrelationIDAsBytes()/getJMSCorrelationIDAsBytes() is optional and it explicitly allows the provider to throw java.lang.UnsupportedOperationException.

We should either pack the raw bytes into the AMQShortString or throw UnsupportedOperationException.

Issue Links

• relates to: QPID-7897 [Java 0-8...0-9-1 Client] Message#getJMSCorrelationIDAsBytes() erroneously first converts to string before retreiving bytes