[QPID-7684] [Java Broker, BDB] Close Cursor when LockConflictException is thrown

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.32, qpid-java-6.0.6, qpid-java-6.1.1, qpid-java-broker-7.0.0
• Fix Version/s: qpid-java-6.1.2, qpid-java-6.0.7, qpid-java-broker-7.0.0
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Lorenz Quack
• Created: 27/Feb/17 14:02
• Updated: 02/Oct/19 19:22
• Resolved: 15/Mar/17 12:58

Description

Currently, when a LockConflictException is thrown we retry the operation.
However the retry logic does not adhere to the rules outlined in the BDB JE documentation, specifically we do not close and recreate the Cursor.
To quote the documentation:

If a lock conflict occurs during a transaction, the transaction may be retried by performing the following steps. [...]:

1. Close all cursors opened under the transaction.
2. Abort the transaction.
3. Begin a new transaction and repeat the operations.

The impact of not doing this is unclear.