[QPID-7658] [Java Broker] Improve LinkRegistry

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: qpid-java-broker-7.0.0
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Lorenz Quack
• Created: 02/Feb/17 14:03
• Updated: 14/Nov/17 22:00
• Resolved: 31/Mar/17 14:50

Description

Currently the AbstractVirtualHost has a Map<remoteContainerId, LinkRegistry>.

The handling of the remoteContainerId should also be encapsulated in the LinkRegistry giving each VH only a single LinkRegistry.
The LinkRegistry is responsible for ensuring Link uniqueness and persistence (separate JIRA).

Furthermore, the following change to the LinkRegistry is proposed:

• LinkRegistry.getSendvingLink(String remoteContrainerId, String linkName) -> Link
• LinkRegistry.getReceivingLink(String remoteContrainerId, String linkName) -> Link
  These should always return a non-null Link. The caller (session) is responsible for checking that the link has valid Source and Targets.
  They also need to be thread-safe (e.g., two calls with the same arguments should return the same object).

The LinkRegistry should also provide facilities to the Link to remove itself from the Registry (for example on Link close, or error) and to update the Termini upon resuming a Link.
If possible this should not be part of the public API. possible API:

• LinkRegistry.removeSendingLink(String localContainerId, String remoteContrainerId, String linkName)
• LinkRegistry.removeReceivingLink(String localContainerId, String remoteContrainerId, String linkName)
• LinkRegistry.updateLinkTermini(Link link, Source source, Target target)

The implementation of which must be thread-safe because the LinkRegistry will be accessed on multiple threads concurrently.

Issue Links

• is depended upon by: QPID-7659 [Java Broker, AMQP 1.0] Support Link stealing
• is depended upon by: QPID-7660 [Java Broker] When recovering a AMQP 1.0 Link the Terminus should be recovered from the LinkRegistry
• is related to: QPID-7540 [Java Broker] The broker cannot recover durable Consumers (AMQP 1.0) which leaves it in an ERRORed state
• is related to: QPID-7663 [Java Broker] Implement persistent storage of LinkRegistry
• relates to: QPID-7657 [Java Broker] Move handling of DeliveryState to Termini