[QPID-7463] [Python Client for AMQP 0-8,0-9] Race condition when creating session

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: qpid-python-1.35.0, qpid-python-1.36.0, qpid-python-1.37.0
• Fix Version/s: qpid-python-1.38.0
• Component/s: Python Client
• Assignee: Unassigned
• Reporter: Lorenz Quack
• Created: 18/Oct/16 14:23
• Updated: 22/Nov/17 17:55

Description

It seems that Client.session() is not thread safe. There seems to be a race condition that means two concurrent calls can actually share the same underlying session.

Client.session() acquires self.lock and determines a free session id. It then releases the lock before calling self.channel(id) which acquires the lock again and allocates the id and creates the session.
If a second call to Client.session() happens in the moment the lock is released but before self.channel(id) reacquires it the second call will find the same free id and will then subsequently return the same session object from self.channel(id).