[QPID-7358] [Java Broker] forbid the same state transition to be defined more than once

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: qpid-java-6.0, qpid-java-6.0.5, qpid-java-6.1
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Lorenz Quack
• Created: 20/Jul/16 14:17
• Updated: 21/Jul/16 09:09
• Resolved: 21/Jul/16 09:09

Description

Currently if we define a state transition more than once, only one will be used and the others will be silently discarded. For example on AbstractVirtualHost the state transition ERRORED -> ACTIVE is defined twice:

@StateTransition(currentState = {State.UNINITIALIZED, State.ERRORED}, desiredState = State.ACTIVE)
private ListenableFuture<Void> onActivate()
{...}

@StateTransition( currentState = { State.STOPPED, State.ERRORED }, desiredState = State.ACTIVE )
private ListenableFuture<Void> onRestart()
{...}

The relevant code that does the discarding is ConfiguredObjectTypeRegistry#addStateTransitions and ConfiguredObjectTypeRegistry#addStateTransition.

I would argue that this should be a compilation error.

Issue Links

• duplicates: QPID-7104 [Java Broker] Creating multiple state transition methods on a ConfiguredObject should cause an error