[QPID-7134] [C++ client] Message::setContent("") does not work

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: qpid-cpp-0.34
• Fix Version/s: qpid-cpp-1.35.0
• Component/s: C++ Client
• Assignee: Gordon Sim
• Reporter: Pavel Moravec
• Created: 10/Mar/16 11:17
• Updated: 06/Sep/16 21:32
• Resolved: 10/Mar/16 22:54

Description

Message::setContent internally updates just "bytes" property of the Message object but not the "content" object. That brings problems when trying to reset content to empty one - original content is still stored in "content" object property and e.g. an attempt to send this "empty" message sends the message with original content.

Reproducer (outside a broker, feel free to add receiving initial message from the broker, or sending the result to it back):

#include <iostream>
#include <qpid/messaging/Message.h>

using namespace std;
using namespace qpid::messaging;

int main(int argc, char* argv[])
{
    qpid::types::Variant content("some content");
    Message m1(content);
    cout << "Message 1: initial content set to \"" << m1.getContent() << "\", contentSize = " << m1.getContentSize() << endl;
    m1.setContent("message 1");
    cout << "Message 1: after content set to \"" << m1.getContent() << "\", contentSize = " << m1.getContentSize() << endl;
    m1.setContent(std::string());
    cout << "Message 1: after content set to an empty string, the content is still \"" << m1.getContent() << "\" and contentSize = " << m1.getContentSize() << endl;

    return 0;
}

That returns:

Message 1: initial content set to "some content", contentSize = 12
Message 1: after content set to "message 1", contentSize = 9
Message 1: after content set to an empty string, the content is still "some content" and contentSize = 12

See "some content" of size 12 returned after an attempt to empty the message content. See it is the original content before first setContent called.