[QPID-701] makeBrokerConnection uses a while sleep() and should be updated to use a wait() notify()

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: M2.1, M3
• Fix Version/s: M3
• Component/s: JMS AMQP 0-x
• Assignee: Martin Ritchie
• Reporter: Martin Ritchie
• Created: 12/Dec/07 11:58
• Updated: 14/Mar/17 20:02
• Resolved: 23/Jul/08 14:13

Description

The makeBrokerConnection poses a problem with failover but not on its own. The use of makeBrokerConnection will start the connection process that if it fails will cause the Failover Thread to handle connection. As can be seen in the AMQConnection constructor the majority of the method needs to be moved in to a connect() method as it lets the failover mechanism handle the failover issue. (It does need to be improved as commented in a //todo there is a Thread.sleep loop that could be replaced with a wait() notify() mechanism.)

The other two cases are related to attempting reconnection due to a redirection which are currently only called as part of the failover mechanism and so should already be wrapped in FailoverSupport

Issue Links

• relates to: QPID-144 Potential deadlocks during failover