[QPID-6817] [Java Broker] On abrupt connection close from client side when Broker is delivering messages to consumer the delivered messages might not be released as part of close in some unlucky circumstances

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: qpid-java-6.0
• Fix Version/s: qpid-java-6.0.1, qpid-java-6.1
• Component/s: Broker-J
• Assignee: Unassigned
• Reporter: Alex Rudyy
• Created: 30/Oct/15 11:25
• Updated: 23/Feb/16 09:33
• Resolved: 22/Feb/16 11:15

Description

With current implementation consumer acquired messages are put into intermediate queue on ConsumerTarget before putting them into wire. The registering of those messages as unacknowledged with session happens letter. When TCP connection is get closed between message being put into a ConsumerTarget queue and registering of it on session as unacknowledged, such message cannot be released as part of session close and can continue remain in ACQUIRED state blocking the queue message flow. Only Broker restart can remediate the issue.

It seems we can fix the issue by introducing a method on a ConsumerTarget to iterate over the messages stored in intermediate queue and call release method on them. The method shall be invoked as part of ConsumerTarget close.