[QPID-6389] [C++ Broker] [AMQP 1.0] consumer attach with a null source leads to unexpected response

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.31
• Fix Version/s: 0.32
• Component/s: C++ Broker
• Assignee: Gordon Sim
• Reporter: Robbie Gemmell
• Created: 13/Feb/15 16:11
• Updated: 19/Mar/15 12:23
• Resolved: 02/Mar/15 11:48

Description

Upon a client attaching a durable consumer link with a null source (not null address), qpidd responds with an attach containing a non-null source with null address, then sends a closing detach with an error indicating no source was specfied. The message "[Protocol] error Error on attach: No source specified!" is output on the broker console.

From the spec, I would expect this to have resulted in either:

• A successfull attach to an existing [possibly detached] link, with the response source indicating the related terminus details.
• Returning an attach with a null source, and then a closing detach without an error, to indicate lack of a matching link.

This behaviour seems to be described at http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp315568 with Fig 2.33 in particular being related, albeit for a producing link.

The JMS clients (old and new) currently do this to 'look up' durable subscriptions by attaching a link with a null source (only during unsubscribe currently, but in future also during subscriber open/creation verification as well), and monitoring the source value in the attach response from the broker.