[QPID-6302] InitialContextFactory implementations modify the provided environment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.30
• Fix Version/s: qpid-java-6.0
• Component/s: JMS AMQP 0-x
• Labels: legacy-jms-amqp-1.0-client
• Assignee: Unassigned
• Reporter: Robbie Gemmell
• Created: 09/Jan/15 15:48
• Updated: 14/Mar/17 12:38
• Resolved: 12/Nov/15 00:13

Description

Both the AMQP 0-x and 1.0 JMS clients modify the environment hashmap provided to them in their InitialContextFactory implementations by adding any properties loaded from a properties file into it. This is against the API requirements[1]:

"The environment parameter is owned by the caller. The implementation will not modify the object or keep a reference to it, although it may keep a reference to a clone or copy.

The affected classes are:
org.apache.qpid.jndi.PropertiesFileInitialContextFactory and org.apache.qpid.amqp_1_0.jms.jndi.PropertiesFileInitialContextFactory

[1] http://docs.oracle.com/javase/7/docs/api/javax/naming/spi/InitialContextFactory.html#getInitialContext(java.util.Hashtable)

Issue Links

• relates to: QPID-6508 PropertiesFileInitialContextFactory silences important exceptions and is non-compliant with the InitialContext interface