Qpid
  1. Qpid
  2. QPID-5202

[Java Broker] Improve exchange documentation in java broker docbook

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.25
    • Component/s: Documentation
    • Labels:
      None

      Description

      Improve exchange documentation in java broker docbook

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1528663 from Keith Wall in branch 'qpid/trunk'
        [ https://svn.apache.org/r1528663 ]

        QPID-5202: [Java Broker] Improve exchange documentation.

        Show
        ASF subversion and git services added a comment - Commit 1528663 from Keith Wall in branch 'qpid/trunk' [ https://svn.apache.org/r1528663 ] QPID-5202 : [Java Broker] Improve exchange documentation.
        Hide
        Keith Wall added a comment -

        I've refreshed the trunk java broker docbook:
        http://qpid.apache.org/books/trunk/AMQP-Messaging-Broker-Java-Book/html/index.html

        Robbie,
        Could you please review the new content? Thanks, Keith.

        Show
        Keith Wall added a comment - I've refreshed the trunk java broker docbook: http://qpid.apache.org/books/trunk/AMQP-Messaging-Broker-Java-Book/html/index.html Robbie, Could you please review the new content? Thanks, Keith.
        Hide
        Robbie Gemmell added a comment -

        Hi Keith,

        Looks good. I'd suggest a few small tweaks as attached, mainly around the default exchange segment, some typos, and quoting things to make them clearer (amq. references as Alex suggested, and also around the routing key + binding key and/or selector matching).

        Outside of these there are some other changes required, but I decided to leave those for you to do later, since this version would actually work better for backporting to documentation for older releases that these points arent true for:

        • All the exchange types now support using selectors in the bindings.
        • The 0-8/0-9/0-9-1 handling of unroutable messages needs updated to reflect the CloseWhenNoRoute functionality.

        Robbie

        Show
        Robbie Gemmell added a comment - Hi Keith, Looks good. I'd suggest a few small tweaks as attached, mainly around the default exchange segment, some typos, and quoting things to make them clearer (amq. references as Alex suggested, and also around the routing key + binding key and/or selector matching). Outside of these there are some other changes required, but I decided to leave those for you to do later, since this version would actually work better for backporting to documentation for older releases that these points arent true for: All the exchange types now support using selectors in the bindings. The 0-8/0-9/0-9-1 handling of unroutable messages needs updated to reflect the CloseWhenNoRoute functionality. Robbie
        Hide
        ASF subversion and git services added a comment -

        Commit 1529848 from Keith Wall in branch 'qpid/trunk'
        [ https://svn.apache.org/r1529848 ]

        QPID-5202: Exchange documentation - incorporate initial feedback

        Feedback from Robbie Gemmell and Oleksandr Rudyy.

        Show
        ASF subversion and git services added a comment - Commit 1529848 from Keith Wall in branch 'qpid/trunk' [ https://svn.apache.org/r1529848 ] QPID-5202 : Exchange documentation - incorporate initial feedback Feedback from Robbie Gemmell and Oleksandr Rudyy.
        Hide
        ASF subversion and git services added a comment -

        Commit 1530439 from Keith Wall in branch 'qpid/trunk'
        [ https://svn.apache.org/r1530439 ]

        QPID-5202: Exchange documentation - correct typos

        Show
        ASF subversion and git services added a comment - Commit 1530439 from Keith Wall in branch 'qpid/trunk' [ https://svn.apache.org/r1530439 ] QPID-5202 : Exchange documentation - correct typos
        Hide
        ASF subversion and git services added a comment -

        Commit 1530440 from Keith Wall in branch 'qpid/trunk'
        [ https://svn.apache.org/r1530440 ]

        QPID-5202: Exchange documentation - include ref to close when no route feature

        Show
        ASF subversion and git services added a comment - Commit 1530440 from Keith Wall in branch 'qpid/trunk' [ https://svn.apache.org/r1530440 ] QPID-5202 : Exchange documentation - include ref to close when no route feature
        Hide
        ASF subversion and git services added a comment -

        Commit 1530441 from Keith Wall in branch 'qpid/trunk'
        [ https://svn.apache.org/r1530441 ]

        QPID-5202: Exchange documentation - binding argument specifying JMS selector arguments are supported by exchange types direct, topic, and fanout.

        Show
        ASF subversion and git services added a comment - Commit 1530441 from Keith Wall in branch 'qpid/trunk' [ https://svn.apache.org/r1530441 ] QPID-5202 : Exchange documentation - binding argument specifying JMS selector arguments are supported by exchange types direct, topic, and fanout.
        Hide
        ASF subversion and git services added a comment -

        Commit 1531561 from Keith Wall in branch 'qpid/trunk'
        [ https://svn.apache.org/r1531561 ]

        QPID-5202: Add licences to SVGs added by this Jira

        Show
        ASF subversion and git services added a comment - Commit 1531561 from Keith Wall in branch 'qpid/trunk' [ https://svn.apache.org/r1531561 ] QPID-5202 : Add licences to SVGs added by this Jira
        Hide
        Keith Wall added a comment -

        Hi Robbie, I have addressed the review comments and added the licences to SVGs. I have refreshed the trunk content beneath /site (both copies). Please can you have a re-review.

        Show
        Keith Wall added a comment - Hi Robbie, I have addressed the review comments and added the licences to SVGs. I have refreshed the trunk content beneath /site (both copies). Please can you have a re-review.
        Hide
        ASF subversion and git services added a comment -

        Commit 1531763 from Robbie Gemmell in branch 'qpid/trunk'
        [ https://svn.apache.org/r1531763 ]

        QPID-5202: tweak wording to cover that CWNR feature doesn't need to be disabled for it to not close the connection

        Show
        ASF subversion and git services added a comment - Commit 1531763 from Robbie Gemmell in branch 'qpid/trunk' [ https://svn.apache.org/r1531763 ] QPID-5202 : tweak wording to cover that CWNR feature doesn't need to be disabled for it to not close the connection
        Hide
        Robbie Gemmell added a comment -

        Looks good, as per the above commit, I made one tiny tweak to the wording to cover the fact that even when enabled Close When No Route might not close the connection (as it only operates on transacted sessions).

        Show
        Robbie Gemmell added a comment - Looks good, as per the above commit, I made one tiny tweak to the wording to cover the fact that even when enabled Close When No Route might not close the connection (as it only operates on transacted sessions).
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.26, http://qpid.apache.org/releases/qpid-0.26/index.html

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Keith Wall
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development