Qpid
  1. Qpid
  2. QPID-5074

[Java Broker] update broker binary release tar process to handle plugins with dependencies

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23
    • Fix Version/s: 0.24
    • Component/s: Java Broker
    • Labels:
      None

      Description

      The process used to create the broker binary release has historically lacked awareness of plugin dependencies, because none of them had any that we distribute. As more functionality has been made pluggable during the 0.24 development cycle, we now have plugins with dependencies we need to take into account and the process must be updated accordingly.

        Activity

        Hide
        Robbie Gemmell added a comment -

        Attached patch for review, which resolves various issues with the plugins noticed from 0.24 RC1 and RC2.

        • makes the broker-plugins/jdbc-provider-bone module be handled as a broker-plugin
        • makes the optional bdbstore module be handled as a broker-plugin
        • ensures the dependencies for the plugins are copied into the release binary (except for those related to the optional bdbstore as we cant distribute them)
        • simplifies the build commands used in the release script now that the plugin deps are handled properly
        Show
        Robbie Gemmell added a comment - Attached patch for review, which resolves various issues with the plugins noticed from 0.24 RC1 and RC2. makes the broker-plugins/jdbc-provider-bone module be handled as a broker-plugin makes the optional bdbstore module be handled as a broker-plugin ensures the dependencies for the plugins are copied into the release binary (except for those related to the optional bdbstore as we cant distribute them) simplifies the build commands used in the release script now that the plugin deps are handled properly
        Hide
        Rob Godfrey added a comment -

        The comment

        <!-- Overridden in amqp-1-0-common, bdbstore, and bdbstore/jmx modules -->
        

        should read

        <!-- Overridden in broker-plugins/amqp-1-0-protocol, bdbstore, and bdbstore/jmx modules -->
        

        Other than that, all looks good, and needs to be in 0.24 (as it is a blocker for the Java release)

        Show
        Rob Godfrey added a comment - The comment <!-- Overridden in amqp-1-0-common, bdbstore, and bdbstore/jmx modules --> should read <!-- Overridden in broker-plugins/amqp-1-0-protocol, bdbstore, and bdbstore/jmx modules --> Other than that, all looks good, and needs to be in 0.24 (as it is a blocker for the Java release)
        Hide
        ASF subversion and git services added a comment -

        Commit 1514654 from Robbie Gemmell in branch 'qpid/trunk'
        [ https://svn.apache.org/r1514654 ]

        QPID-5074: update broker binary release tar process to handle plugins with dependencies, fix issues with generated poms

        Show
        ASF subversion and git services added a comment - Commit 1514654 from Robbie Gemmell in branch 'qpid/trunk' [ https://svn.apache.org/r1514654 ] QPID-5074 : update broker binary release tar process to handle plugins with dependencies, fix issues with generated poms
        Hide
        Justin Ross added a comment - - edited
        Show
        Justin Ross added a comment - - edited Reviewed by Rob. Approved for 0.24. http://qpid.2158936.n2.nabble.com/Request-for-inclusion-in-0-24-tt7597021.html
        Hide
        ASF subversion and git services added a comment -

        Commit 1515332 from Robbie Gemmell in branch 'qpid/branches/0.24'
        [ https://svn.apache.org/r1515332 ]

        QPID-5074: update broker binary release tar process to handle plugins with dependencies, fix issues with generated poms

        merged from trunk r1514654

        Show
        ASF subversion and git services added a comment - Commit 1515332 from Robbie Gemmell in branch 'qpid/branches/0.24' [ https://svn.apache.org/r1515332 ] QPID-5074 : update broker binary release tar process to handle plugins with dependencies, fix issues with generated poms merged from trunk r1514654
        Hide
        Robbie Gemmell added a comment -

        Resolving, now merged to 0.24 branch.

        Show
        Robbie Gemmell added a comment - Resolving, now merged to 0.24 branch.
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Robbie Gemmell
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development