Qpid
  1. Qpid
  2. QPID-5031

WiX installer generator flags deprecated usage on RegistryKey directive

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.24, 0.25
    • Fix Version/s: 0.24, 0.25
    • Component/s: Packaging
    • Labels:
      None
    • Environment:

      Windows, WiX Toolset v3.6

      Description

      When generating the Windows MSI installer, the WiX toolset flags the usage of the Action="create" modifer on the RegistryKey directive used to set up the WCF XA support as deprecated - the modifier is not needed. I have tested without that modifer and the generated MSI installs correctly and sets the registry key correctly.

      1. qpidc.wxs.diff
        0.7 kB
        Steve Huston

        Activity

        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Hide
        ASF subversion and git services added a comment -

        Commit 1510850 from Steve Huston in branch 'qpid/branches/0.24'
        [ https://svn.apache.org/r1510850 ]

        QPID-5031 merged to 0.24

        Show
        ASF subversion and git services added a comment - Commit 1510850 from Steve Huston in branch 'qpid/branches/0.24' [ https://svn.apache.org/r1510850 ] QPID-5031 merged to 0.24
        Hide
        Justin Ross added a comment -

        Reviewed by Chuck. Approved for 0.24.

        Show
        Justin Ross added a comment - Reviewed by Chuck. Approved for 0.24.
        Hide
        Chuck Rolke added a comment -

        Ship It!

        Show
        Chuck Rolke added a comment - Ship It!
        Hide
        Justin Ross added a comment -

        Chuck, did you get a chance to look over the patch?

        Show
        Justin Ross added a comment - Chuck, did you get a chance to look over the patch?
        Hide
        Steve Huston added a comment -

        Chuck, I'm not at all sure how I got a review board entry without the diff. I uploaded the diff to create the entry. Anyway, I attached the patch to this jira as well.

        Show
        Steve Huston added a comment - Chuck, I'm not at all sure how I got a review board entry without the diff. I uploaded the diff to create the entry. Anyway, I attached the patch to this jira as well.
        Hide
        ASF subversion and git services added a comment -

        Commit 1509969 from Steve Huston in branch 'qpid/trunk'
        [ https://svn.apache.org/r1509969 ]

        QPID-5031: Remove deprecated Action modifier.

        Show
        ASF subversion and git services added a comment - Commit 1509969 from Steve Huston in branch 'qpid/trunk' [ https://svn.apache.org/r1509969 ] QPID-5031 : Remove deprecated Action modifier.
        Hide
        Chuck Rolke added a comment -

        Steve,

        There's no diff attached to the review. (How did you do that?!!) Could you post the patch to the review or to this jira?

        I'm not that familiar with the WiX toolset and would defer to you decision on whether to Ship It or not. I don't have WiX installed nor have I run it to create an installation.

        -Chuck

        Show
        Chuck Rolke added a comment - Steve, There's no diff attached to the review. (How did you do that?!!) Could you post the patch to the review or to this jira? I'm not that familiar with the WiX toolset and would defer to you decision on whether to Ship It or not. I don't have WiX installed nor have I run it to create an installation. -Chuck
        Hide
        Steve Huston added a comment -

        Review board request: https://reviews.apache.org/r/13125/

        I would like to merge this to 0.24. Chuck Rolke's review requested.

        Show
        Steve Huston added a comment - Review board request: https://reviews.apache.org/r/13125/ I would like to merge this to 0.24. Chuck Rolke's review requested.

          People

          • Assignee:
            Steve Huston
            Reporter:
            Steve Huston
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development