Qpid
  1. Qpid
  2. QPID-5028

Qmf2 examples install script error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22
    • Fix Version/s: 0.24
    • Component/s: Packaging
    • Labels:
      None
    • Environment:

      Windows cmake install

      Description

      Files are not located at CMAKE_CURRENT_SOURCE_DIR

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        5d 17h 45m 1 Chuck Rolke 05/Aug/13 15:35
        Resolved Resolved Closed Closed
        33d 23h 1m 1 Justin Ross 08/Sep/13 14:37
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Chuck Rolke made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.24 [ 12324776 ]
        Resolution Fixed [ 1 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1509739 from chug@apache.org in branch 'qpid/branches/0.24'
        [ https://svn.apache.org/r1509739 ]

        QPID-5028: Qmf2 examples install script error - merge fix to 0.24 release branch

        Show
        ASF subversion and git services added a comment - Commit 1509739 from chug@apache.org in branch 'qpid/branches/0.24' [ https://svn.apache.org/r1509739 ] QPID-5028 : Qmf2 examples install script error - merge fix to 0.24 release branch
        Hide
        Justin Ross added a comment -

        Reviewed by Cliff. Approved for 0.24.

        Show
        Justin Ross added a comment - Reviewed by Cliff. Approved for 0.24.
        Hide
        ASF subversion and git services added a comment -

        Commit 1508967 from chug@apache.org in branch 'qpid/trunk'
        [ https://svn.apache.org/r1508967 ]

        QPID-5028: Qmf2 examples install script error
        Don't try to install files that don't exist.
        This patch may be superseded by new CMake files or by the addition of the .sln and .vcproj that are currently missing.

        Show
        ASF subversion and git services added a comment - Commit 1508967 from chug@apache.org in branch 'qpid/trunk' [ https://svn.apache.org/r1508967 ] QPID-5028 : Qmf2 examples install script error Don't try to install files that don't exist. This patch may be superseded by new CMake files or by the addition of the .sln and .vcproj that are currently missing.
        Hide
        Chuck Rolke added a comment -

        The windows installation of the qmf2 examples in cpp/bindings/qmf2/examples/cpp follows the same cmake script pattern of cpp/examples/messaging. In examples/messaging there is a .sln file and associated .vcproj files checked right in to the source tree. During the qmf2 installation these files are absent and the installation fails.

        Now the question is what to do about it. I think there are two choices:

        1. Strip out the .sln and .vcproj files from examples/messaging and replace them with CMakeList.txt files. Add new cmake support for qmf2.
        This is how the WinSDK delivers the examples/messaging example files.
        It imposes the burden of end users running cmake
        It generates solution (.sln) and project (.vcproj, .vcxproj) files for 32- and 64-bit architectures with any cmake-supported version of Visual Studio. This future-proofs the delivery of windows examples.

        2. Add Visual Studio 2008 .sln and .vcproj files to the qmf2/examples directory.
        If we use Choice 2 I suggest using VS2008 .sln and .vcproj examples. These can be upgraded in place by a customer with a later version of Visual Studio.
        VS2008 is three generations old. Adding files for it now seems dated and undesirable.

        I favor Choice 1.

        Show
        Chuck Rolke added a comment - The windows installation of the qmf2 examples in cpp/bindings/qmf2/examples/cpp follows the same cmake script pattern of cpp/examples/messaging. In examples/messaging there is a .sln file and associated .vcproj files checked right in to the source tree. During the qmf2 installation these files are absent and the installation fails. Now the question is what to do about it. I think there are two choices: 1. Strip out the .sln and .vcproj files from examples/messaging and replace them with CMakeList.txt files. Add new cmake support for qmf2. This is how the WinSDK delivers the examples/messaging example files. It imposes the burden of end users running cmake It generates solution (.sln) and project (.vcproj, .vcxproj) files for 32- and 64-bit architectures with any cmake-supported version of Visual Studio. This future-proofs the delivery of windows examples. 2. Add Visual Studio 2008 .sln and .vcproj files to the qmf2/examples directory. If we use Choice 2 I suggest using VS2008 .sln and .vcproj examples. These can be upgraded in place by a customer with a later version of Visual Studio. VS2008 is three generations old. Adding files for it now seems dated and undesirable. I favor Choice 1.
        Chuck Rolke created issue -

          People

          • Assignee:
            Chuck Rolke
            Reporter:
            Chuck Rolke
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development