Qpid
  1. Qpid
  2. QPID-4994

[Java Client] Remove redundant BindingURL options and stop special-casing queues on topic exchanges

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18, 0.20, 0.22
    • Fix Version/s: 0.24
    • Component/s: Java Client
    • Labels:
      None

      Description

      Binding URL options for subscription name and client ID ("subscription" and "clientid" respectively) are not currently used by the JMS client. Instead the durable subscription destination is generated with org.apache.qpid.client.AMQTopic.createDurableTopic(Topic, String, AMQConnection). More over, the BindingURLParser mistreats the queue binding URLs to the topic exchanges and sets the queue name to null if it is non-durable or throws URISyntaxException if it is durable.

      BindingURLParser should not change any binding URL setting and parsing results should correspond to the binding URL settings specified by the user

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1504185 from orudyy@apache.org in branch 'qpid/trunk'
        [ https://svn.apache.org/r1504185 ]

        QPID-4994: Remove redundant binding URL options for subscription name and client id

        Show
        ASF subversion and git services added a comment - Commit 1504185 from orudyy@apache.org in branch 'qpid/trunk' [ https://svn.apache.org/r1504185 ] QPID-4994 : Remove redundant binding URL options for subscription name and client id
        Hide
        Alex Rudyy added a comment -

        Robbie,

        Could you please review the changes?

        Show
        Alex Rudyy added a comment - Robbie, Could you please review the changes?
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development