Qpid
  1. Qpid
  2. QPID-4994

[Java Client] Remove redundant BindingURL options and stop special-casing queues on topic exchanges

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.6, 0.8, 0.10, 0.12, 0.14, 0.16, 0.18, 0.20, 0.22
    • Fix Version/s: 0.24
    • Component/s: Java Client
    • Labels:
      None

      Description

      Binding URL options for subscription name and client ID ("subscription" and "clientid" respectively) are not currently used by the JMS client. Instead the durable subscription destination is generated with org.apache.qpid.client.AMQTopic.createDurableTopic(Topic, String, AMQConnection). More over, the BindingURLParser mistreats the queue binding URLs to the topic exchanges and sets the queue name to null if it is non-durable or throws URISyntaxException if it is durable.

      BindingURLParser should not change any binding URL setting and parsing results should correspond to the binding URL settings specified by the user

        Activity

        Alex Rudyy created issue -
        Alex Rudyy made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1504185 from orudyy@apache.org in branch 'qpid/trunk'
        [ https://svn.apache.org/r1504185 ]

        QPID-4994: Remove redundant binding URL options for subscription name and client id

        Show
        ASF subversion and git services added a comment - Commit 1504185 from orudyy@apache.org in branch 'qpid/trunk' [ https://svn.apache.org/r1504185 ] QPID-4994 : Remove redundant binding URL options for subscription name and client id
        Alex Rudyy made changes -
        Status In Progress [ 3 ] Ready To Review [ 10006 ]
        Hide
        Alex Rudyy added a comment -

        Robbie,

        Could you please review the changes?

        Show
        Alex Rudyy added a comment - Robbie, Could you please review the changes?
        Alex Rudyy made changes -
        Assignee Alex Rudyy [ alex.rufous ] Robbie Gemmell [ gemmellr ]
        Robbie Gemmell made changes -
        Summary [Java Client] Remove redundant binding URL options for subscription name and client id [Java Client] Remove redundant BindingURL options and stop special-casing queues on topic exchanges
        Robbie Gemmell made changes -
        Status Ready To Review [ 10006 ] Resolved [ 5 ]
        Fix Version/s 0.24 [ 12324776 ]
        Resolution Fixed [ 1 ]
        Hide
        Justin Ross added a comment -
        Show
        Justin Ross added a comment - Released in Qpid 0.24, http://qpid.apache.org/releases/qpid-0.24/index.html
        Justin Ross made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        16s 1 Alex Rudyy 17/Jul/13 16:39
        In Progress In Progress Reviewable Reviewable
        33m 37s 1 Alex Rudyy 17/Jul/13 17:13
        Reviewable Reviewable Resolved Resolved
        11d 17h 6m 1 Robbie Gemmell 29/Jul/13 10:19
        Resolved Resolved Closed Closed
        41d 4h 17m 1 Justin Ross 08/Sep/13 14:37

          People

          • Assignee:
            Robbie Gemmell
            Reporter:
            Alex Rudyy
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development